Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): BREAKING CHANGE replace jQueryUI by SortableJS in common & DraggableGrouping #772

Merged
merged 5 commits into from
Oct 16, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 15, 2022

Next Major TODOs

  • replace jQueryUI Autocomplete with Kraaden Autocomplete
  • remove jQueryUI from core & SlickDraggableGrouping and replace with SortableJS
    • add full unit test coverage
  • remove all deprecations from last release
    • ie, remove all image url deprecation since only css classes now
    • take care of all other deprecations found, replace exportOptions by textExportOptions and its related flag
  • replace jquery.event.drag-2.3.0.js and jquery.mousewheel libs with slick.interactions.js
  • requires new SlickGrid 3.x major release (Wiki)
  • create Migration 2.x Wiki
  • release an alpha version to update Angular-Slickgrid/Aurelia-Slickgrid

…#752)

* feat(common): replace jQueryUI Autocomplete with Kradeen Autocomplete
- first step in order to remove jQueryUI
…SlickDraggableGrouping (#756)

* feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

Merging #772 (5abda29) into master (7e65bcb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master      #772    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          233       234     +1     
  Lines        16433     16378    -55     
  Branches      5490      5721   +231     
==========================================
- Hits         16433     16378    -55     
Impacted Files Coverage Δ
.../src/commonEditorFilter/commonEditorFilterUtils.ts 100.00% <100.00%> (ø)
packages/common/src/commonEditorFilter/index.ts 100.00% <100.00%> (ø)
packages/common/src/editors/autocompleterEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/editors.index.ts 100.00% <100.00%> (ø)
packages/common/src/editors/index.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/menuBaseClass.ts 100.00% <100.00%> (ø)
...ges/common/src/extensions/menuFromCellBaseClass.ts 100.00% <100.00%> (ø)
...common/src/extensions/slickCellExcelCopyManager.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickCellMenu.ts 100.00% <100.00%> (ø)
...es/common/src/extensions/slickCellRangeSelector.ts 100.00% <100.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding changed the title WIP - feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping Oct 16, 2022
@ghiscoding ghiscoding changed the title feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping feat(common): BREAKING CHANGE replace jQueryUI with SortableJS in common & DraggableGrouping Oct 16, 2022
@ghiscoding ghiscoding merged commit a9db2cc into master Oct 16, 2022
@ghiscoding ghiscoding deleted the next branch October 16, 2022 16:57
@ghiscoding ghiscoding changed the title feat(common): BREAKING CHANGE replace jQueryUI with SortableJS in common & DraggableGrouping feat(common): BREAKING CHANGE replace jQueryUI by SortableJS in common & DraggableGrouping Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant