Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editors): add Column Editor collectionOverride option #228

Merged
merged 4 commits into from
Jan 6, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jan 6, 2021

  • only applies to Editor with collection (autocomplete & single/multiple select)

@ghiscoding ghiscoding changed the title feat(editors): add Column Editor collectionOverride option WIP - feat(editors): add Column Editor collectionOverride option Jan 6, 2021
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #228 (e7d803f) into master (526881f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #228   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        11871     11876    +5     
  Branches      4079      4072    -7     
=========================================
+ Hits         11871     11876    +5     
Impacted Files Coverage Δ
packages/common/src/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/floatEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/integerEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/textEditor.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 526881f...e7d803f. Read the comment docs.

@ghiscoding ghiscoding changed the title WIP - feat(editors): add Column Editor collectionOverride option feat(editors): add Column Editor collectionOverride option Jan 6, 2021
@ghiscoding ghiscoding merged commit 91421fc into master Jan 6, 2021
@ghiscoding ghiscoding deleted the feat/editor-collection-override branch January 6, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant