Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): refactor code using the container service everywhere #197

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

ghiscoding
Copy link
Owner

  • also removed the internalPubSubService since it's no longer necessary because we can now get it from the container instead

- also removed the `internalPubSubService` since it's no longer necessary because we can now get it from the container instead
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #197 (f3d8cbd) into master (17fa349) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #197   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          206       206           
  Lines        11835     11833    -2     
  Branches      4036      4041    +5     
=========================================
- Hits         11835     11833    -2     
Impacted Files Coverage Δ
packages/common/src/services/shared.service.ts 100.00% <ø> (ø)
...ackages/common/src/services/excelExport.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/textExport.service.ts 100.00% <100.00%> (ø)
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)
packages/text-export/src/textExport.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)
.../vanilla-bundle/src/services/textExport.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fa349...f3d8cbd. Read the comment docs.

@ghiscoding ghiscoding merged commit 96ce9bd into master Dec 14, 2020
@ghiscoding ghiscoding deleted the feat/use-container-service branch December 14, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant