Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add registerExternalResources for Components/Services #196

Merged
merged 8 commits into from
Dec 14, 2020
Merged

feat(core): add registerExternalResources for Components/Services #196

merged 8 commits into from
Dec 14, 2020

Commits on Dec 12, 2020

  1. fix(stylings): composite editor styling fixes for BS4

    @ghiscoding
    ghiscoding committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    932133a View commit details
    Browse the repository at this point in the history

  2. refactor: tweak composite editor slider value

    @ghiscoding
    ghiscoding committed Dec 12, 2020
    Configuration menu
    Copy the full SHA
    0050f6b View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. refactor(stylings): fix pagination icons alignment with BS4

    @ghiscoding
    ghiscoding committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    e4696db View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. feat(core): add registerExternalResources for Components/Services 

    - renamed `registerExternalServices` to `registerExternalResources` to have a more generic name that can register both Components and/or Services
- use the new `registerExternalResources` to register the SlickCompositeEditorComponent to take full advantage of the monorepo
    @ghiscoding
    ghiscoding committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    6f5a6d8 View commit details
    Browse the repository at this point in the history

  2. refactor: use the new registerExternalResources everywhere

    @ghiscoding
    ghiscoding committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    c99b55e View commit details
    Browse the repository at this point in the history

  3. fix(tests): refactor registeredResources code and fix all unit tests

    @ghiscoding
    ghiscoding committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    0befec9 View commit details
    Browse the repository at this point in the history

  4. tests: add missing unit test

    @ghiscoding
    ghiscoding committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    3d0c5c9 View commit details
    Browse the repository at this point in the history

  5. refactor: add more typings into composite editor component

    @ghiscoding
    ghiscoding committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    5ddd412 View commit details
    Browse the repository at this point in the history