Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): showing/hiding column shouldn't affect its freezing position #185

Merged
merged 5 commits into from
Dec 2, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 2, 2020

  • when calling "hide column" we need to readjust the freezingColumn by (-1) when on left container
  • when showing/hiding a column from ColumnPicker/GridMenu, we need to check if we need to also readjust when column is on the left container

TODOs

  • add all Jest unit tests
  • add Cypress E2E test
  • requires core SlickGrid PR #561 to be merged & released

nAiAGpimeG

- when calling "hide column" we need to readjust the freezingColumn by (-1) when on left container
- when showing/hiding a column from ColumnPicker/GridMenu, we need to check if we need to also readjust when column is on the left container
@ghiscoding ghiscoding changed the title fix(core): showing/hiding a column shouldn't affect freezing position fix(core): showing/hiding column shouldn't affect its freezing position Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #185 (1cddb3e) into master (e7db0fd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #185   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          202       202           
  Lines        11710     11743   +33     
  Branches      3841      3856   +15     
=========================================
+ Hits         11710     11743   +33     
Impacted Files Coverage Δ
...ges/common/src/extensions/columnPickerExtension.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/extensionUtility.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/services/shared.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7db0fd...1cddb3e. Read the comment docs.

@ghiscoding ghiscoding merged commit 2a812ed into master Dec 2, 2020
@ghiscoding ghiscoding deleted the bugfix/hiding-showing-frozen-column-index branch December 2, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant