Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: column.editor and gridOptions.editorFactory type changed #1428

Merged
merged 4 commits into from
Mar 11, 2024
Merged

fix: column.editor and gridOptions.editorFactory type changed #1428

merged 4 commits into from
Mar 11, 2024

Commits on Mar 11, 2024

  1. fix: column.editor and gridOptions.editorFactory type changed 

    as per SlickGrid PR
> editor and editor factory do not return an Editor Object but a typeof Editor to be constructed with new (...) Otherwise it is impossible to implement an Editor Factory in TypeScript
    @ghiscoding-SE
    ghiscoding-SE committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    e321a3e View commit details
    Browse the repository at this point in the history

  2. chore: keep editor as any type until next major release

    @ghiscoding-SE
    ghiscoding-SE committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    dbd98d1 View commit details
    Browse the repository at this point in the history

  3. chore: remove unused import

    @ghiscoding-SE
    ghiscoding-SE committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    26186d7 View commit details
    Browse the repository at this point in the history

  4. chore: refactor code to improve test coverage

    @ghiscoding-SE
    ghiscoding-SE committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    67a2507 View commit details
    Browse the repository at this point in the history