Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getCellFromPoint() should return row/cell -1 outside grid canvas #1325

Merged
merged 6 commits into from
Jan 15, 2024
Merged

fix: getCellFromPoint() should return row/cell -1 outside grid canvas #1325

merged 6 commits into from
Jan 15, 2024

Commits on Jan 12, 2024

  1. fix(core): getCellFromPoint() shouldn't return negative row/cell

    @ghiscoding
    ghiscoding committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    0a6007b View commit details
    Browse the repository at this point in the history

  2. chore: fix failing unit test

    @ghiscoding
    ghiscoding committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    c1d436c View commit details
    Browse the repository at this point in the history

  3. chore: simplify code in getCellFromPoint()

    @ghiscoding
    ghiscoding committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    2e91ef1 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. chore: return -1 when outside grid canvas

    @ghiscoding-SE
    ghiscoding-SE committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    dde82dd View commit details
    Browse the repository at this point in the history

  2. chore: add more test to cover getCellFromPoint()

    @ghiscoding-SE
    ghiscoding-SE committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    857fb98 View commit details
    Browse the repository at this point in the history

  3. chore: add test comment for better understanding

    @ghiscoding-SE
    ghiscoding-SE committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    1939cae View commit details
    Browse the repository at this point in the history