Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(utils): remove unnecessary objectAssignAndExtend method #1280

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 22, 2023

  • we can use node-extend which does the job and already has plenty of unit tests
  • this also makes the build slightly smaller by removing a few lines of code

- we can use `node-extend` which does the job and already has plenty of unit tests
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d60a9d) 88.0% compared to head (9d8ddb8) 88.0%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1280     +/-   ##
========================================
- Coverage    88.0%   88.0%   -0.0%     
========================================
  Files         198     198             
  Lines       21361   21350     -11     
  Branches     7103    7099      -4     
========================================
- Hits        18797   18786     -11     
  Misses       2564    2564             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit f6dc75c into master Dec 22, 2023
5 checks passed
@ghiscoding ghiscoding deleted the chore/remove-utils-object-assign-method branch December 22, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant