Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: registered external resouces should keep singleton ref #1242

Merged
merged 4 commits into from
Dec 2, 2023

Commits on Dec 1, 2023

  1. fix: registered external resouces should keep singleton ref

    - external resources can be provided through the grid options, but these options are sometime deep copied and that might have the side effect of losing the singleton ref of the instantiate services/resources, instead we can simply keep these singleton refs before any grid options merge can happen and that is in the constructor before the grid initializes and before the grid options are merged and sometime deep copied with global options
    ghiscoding-SE committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    6ef74a8 View commit details
    Browse the repository at this point in the history
  2. chore: deprecate registerExternalResources and add method

    - add `registerExternalResources` method to push extra external resources
    - rename grid option (deprecate previous name) `registerExternalResources` because it's confusing with the method name and an option shouldn't be named with something that sound like an execution
    - add `resetExternalResources()` method but that is mostly useful for unit tests
    ghiscoding-SE committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    fd42f0e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5a019fb View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Configuration menu
    Copy the full SHA
    ea8ce74 View commit details
    Browse the repository at this point in the history