Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subMenuOpenByEvent option to open sub-menus via mouseover #1161

Merged
merged 2 commits into from
Oct 29, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 29, 2023

  • when first implemented sub-menus, I thought it was complex to add open sub-menus via mouseover (not just click event) but it turns out to be quite easy with the latest code that was put in place for sub-menus. So this PR adds the mouseover option and does make it the default event (we have 2 options: click or mouseover and the latter is the default)
  • this new mouseover will be the default but user could change it to work via click event only by changing the option to subMenuOpenByEvent: 'click' (instead of the default which is subMenuOpenByEvent: 'mouseover')

wLm68CTQhu

@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #1161 (a54db8e) into master (b524ef1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1161   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        17147     17166   +19     
  Branches      6186      6196   +10     
=========================================
+ Hits         17147     17166   +19     
Files Coverage Δ
packages/common/src/extensions/menuBaseClass.ts 100.00% <100.00%> (ø)
...ges/common/src/extensions/menuFromCellBaseClass.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickCellMenu.ts 100.00% <ø> (ø)
packages/common/src/extensions/slickContextMenu.ts 100.00% <ø> (ø)
packages/common/src/extensions/slickGridMenu.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickHeaderMenu.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit 609f88b into master Oct 29, 2023
5 checks passed
@ghiscoding ghiscoding deleted the feat/menu-mouseover branch October 29, 2023 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant