Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(presets): dynamic columns should be auto-inserted with Grid Presets #938

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix(presets): dynamic columns should be auto-inserted with Grid Presets #938

merged 1 commit into from
Mar 22, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 22, 2023 •
edited
Loading

  • this PR fixes 2 issues
  1. when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't, this was caused by both extensions using the same field name "sel" causing duplicate checkboxes (see print screen)
  2. there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when columns presets are used

image

@ghiscoding
fix(presets): dynamic columns should be auto-inserted with Grid Presets
2f2cae9 
- this PR fixes 2 issues
1. when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see print screen)
2. there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when columns presets are used
@ghiscoding ghiscoding mentioned this pull request Mar 22, 2023
Merged
2 tasks
@codecov
Copy link

codecov bot commented Mar 22, 2023 •
edited
Loading

Codecov Report

Merging #938 (2f2cae9) into master (7033fbf) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #938   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16604     16618   +14     
  Branches      5906      5915    +9     
=========================================
+ Hits         16604     16618   +14
Impacted Files Coverage Δ
...common/src/extensions/slickCheckboxSelectColumn.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/slickRowMoveManager.ts 100.00% <100.00%> (ø)
...s/row-detail-view-plugin/src/slickRowDetailView.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 1f9c1c4 into master Mar 22, 2023
@ghiscoding ghiscoding deleted the bugfix/dynamic-columns-with-presets branch March 22, 2023 19:45
ghiscoding added a commit to ghiscoding/aurelia-slickgrid that referenced this pull request Mar 23, 2023
@ghiscoding
fix(presets): dynamic columns should be auto-inserted with Grid Presets
27cc3e0 
- there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets
- the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen)
  - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
@ghiscoding ghiscoding mentioned this pull request Mar 23, 2023
Merged
2 tasks
ghiscoding added a commit to ghiscoding/aurelia-slickgrid that referenced this pull request Mar 23, 2023
@ghiscoding
fix(presets): dynamic columns should be auto-inserted with Grid Prese…
ea47f46 
…ts (#955)

* fix(presets): dynamic columns should be auto-inserted with Grid Presets
- there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets
- the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen)
  - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
ghiscoding added a commit to ghiscoding/slickgrid-react that referenced this pull request Mar 23, 2023
@ghiscoding
fix(presets): dynamic columns should be auto-inserted with Grid Presets
12d50a4 
- there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets
- the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen)
  - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
@ghiscoding ghiscoding mentioned this pull request Mar 23, 2023
Merged
ghiscoding added a commit to ghiscoding/slickgrid-react that referenced this pull request Mar 23, 2023
@ghiscoding
fix(presets): dynamic columns should be auto-inserted with Grid Prese…
df7f777 
…ts (#74)

- there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets
- the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen)
  - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghiscoding