Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): dynamic columns should be auto-inserted with Grid Presets #955

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

ghiscoding
Copy link
Owner

  • there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets
  • the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen)
    • this is fixed in Slickgrid-Universal PR 938

TODOs

  • requires a new Slickgrid-Universal version
  • add new unit tests coverage

Using all 3 extensions (RowMove, RowSelection & RowDetail) now works correctly when used with Grid Presets

the following presets now works

presets: {
  columns: [
    { columnId: 'title' },
    { columnId: 'duration' },
    { columnId: 'start' },
    { columnId: 'finish' },
    { columnId: 'percent2' },
    { columnId: 'effort-driven' }
  ]
}

is now correctly bringing back all 3 dynamically created columns as shown below
image

2nd Bug will be fixed in Slickgrid-Universal PR 938

image

- there are 3 dynamically created columns (RowMove, RowSelection & RowDetail) and all 3 should be auto-inserted when enabled and used with columns presets
- the 2nd issue will be fixed in Slickgrid-Universal, the issue is when Row Detail & Row Selection are used together, an extra checkbox appears in the filter section of the RowDetail column when it shouldn't (see 2nd print screen)
  - this is fixed in Slickgrid-Universal [PR 938](ghiscoding/slickgrid-universal#938)
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #955 (4aa682d) into master (7712848) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #955   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          969       983   +14     
  Branches       322       331    +9     
=========================================
+ Hits           969       983   +14     
Impacted Files Coverage Δ
...lia-slickgrid/custom-elements/aurelia-slickgrid.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit ea47f46 into master Mar 23, 2023
@ghiscoding ghiscoding deleted the bugfix/dynamic-columns-with-presets branch March 23, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant