Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common)!: replace jQueryUI by SortableJS in common & SlickDraggableGrouping #756

Merged
merged 20 commits into from
Oct 15, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 28, 2022

Next Major TODOs

  • replace jQueryUI Autocomplete with Kraaden Autocomplete
  • remove jQueryUI from core & SlickDraggableGrouping and replace with SortableJS
    • add full unit test coverage
  • remove all deprecations from last release
    • ie, remove all image url deprecation since we now use only css classes
    • take care of all other deprecations found, replace exportOptions by textExportOptions and its enable flag
  • replace jquery.event.drag-2.3.0.js and jquery.mousewheel libs with slick.interactions.js
  • move all common Editors/Filters getter/setter to a base class instead of an abstract class
    • I might just delay this for future changes
  • look at alternatives for SliderRange or simply drop it without replacement
  • requires new SlickGrid 3.x major release (Wiki)
  • create Migration 2.x Wiki

@ghiscoding ghiscoding changed the title Feat/replace jqueryui by sortablejs feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping Aug 28, 2022
- `exportOptions` was replaced by `textExportOptions`
- `enableExport` was replaced by `enableTextExport`
@ghiscoding ghiscoding changed the title feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping WIP - feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping Aug 28, 2022
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #756 (3269b32) into next (9101fff) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              next      #756   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          233       234    +1     
  Lines        16433     16378   -55     
  Branches      5490      5498    +8     
=========================================
- Hits         16433     16378   -55     
Impacted Files Coverage Δ
.../src/commonEditorFilter/commonEditorFilterUtils.ts 100.00% <100.00%> (ø)
packages/common/src/commonEditorFilter/index.ts 100.00% <100.00%> (ø)
packages/common/src/editors/autocompleterEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/editors.index.ts 100.00% <100.00%> (ø)
packages/common/src/editors/index.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/menuBaseClass.ts 100.00% <100.00%> (ø)
...ges/common/src/extensions/menuFromCellBaseClass.ts 100.00% <100.00%> (ø)
...common/src/extensions/slickCellExcelCopyManager.ts 100.00% <100.00%> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding changed the title WIP - feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping Oct 13, 2022
@ghiscoding ghiscoding merged commit b1c5a84 into next Oct 15, 2022
@ghiscoding ghiscoding deleted the feat/replace-jqueryui-by-sortablejs branch October 15, 2022 04:45
ghiscoding added a commit that referenced this pull request Oct 16, 2022
…mon & DraggableGrouping (#772)

* feat(common): replace jQueryUI Autocomplete with Kradeen Autocomplete (#752)

* feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping  (#756)
@ghiscoding ghiscoding changed the title feat(common)!: remove & replace jQueryUI with SortableJS in common & SlickDraggableGrouping feat(common)!: replace jQueryUI by SortableJS in common & SlickDraggableGrouping Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants