Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add registerExternalResources for Components/Services #196

Merged
merged 8 commits into from
Dec 14, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 14, 2020

  • renamed registerExternalServices to registerExternalResources to have a more generic name that can register both Components and/or Services
  • use the new registerExternalResources to register the SlickCompositeEditorComponent to take full advantage of the monorepo

- renamed `registerExternalServices` to `registerExternalResources` to have a more generic name that can register both Components and/or Services
- use the new `registerExternalResources` to register the SlickCompositeEditorComponent to take full advantage of the monorepo
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #196 (5ddd412) into master (fcf4bc1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #196    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          204       206     +2     
  Lines        11783     11835    +52     
  Branches      4025      3889   -136     
==========================================
+ Hits         11783     11835    +52     
Impacted Files Coverage Δ
packages/common/src/index.ts 100.00% <ø> (ø)
...ages/common/src/extensions/contextMenuExtension.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/services/container.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/index.ts 100.00% <100.00%> (ø)
packages/common/src/services/shared.service.ts 100.00% <100.00%> (ø)
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)
packages/vanilla-bundle/src/services/index.ts 100.00% <100.00%> (ø)
...-bundle/src/services/universalContainer.service.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf4bc1...5ddd412. Read the comment docs.

@ghiscoding ghiscoding merged commit ee02f1d into master Dec 14, 2020
@ghiscoding ghiscoding deleted the feat/basic-dependency-injection-container branch December 14, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant