-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home/End keys in active editor #1686
Comments
Hmm I'm not sure what is Pos1, perhaps it's because I'm currently on the laptop. So far, what I can find is that there's some arrow listener in the input editor for arrow left/right, but anything else with Ctrl is about copy/paste for Ctrl+C, Ctrl+V, Ctrl+S or Ctrl+Z apart from that I'm not sure what would catch the event, you can maybe debug that in developer tool. slickgrid-universal/packages/common/src/editors/inputEditor.ts Lines 115 to 121 in 3c6ce20
Also another important thing to note is that cell navigation is really only working when |
oops sry I'm used to german layouts and Pos1 (Position1) is its take on the home key 😅 the ctrl + left/right works because the same listener is stopping direct propagation. and yeah that would be exactly the place where I'd try to extend the listener to the other two keys. my main question is still whether you think this is a bug or working as expected |
most probably an unwanted behavior, so I would think the same as you and consider this a bug |
fix: home and end keys stop propagation on input based editors, closes #1686
Describe the bug
When a cell editor is focused, the arrow keys left and right are intercepted and cell navigation disabled. This is good as it allows to navigate within the Inputs text. Same works with CTRL + Left/Right to jump to start/end of the editor.
what does not work is hitting the pos1 (jumps to first cell of row) or end key (jumps to last cell of the active row)
I wonder whether this is an expected behavior or a bug. I can provide a PR if this indeed is an unintended behavior
Reproduction
see above
Which Framework are you using?
Angular
Environment Info
Validations
The text was updated successfully, but these errors were encountered: