Skip to content

Commit

Permalink
chore(styling): remove unnecessary double imports & commented code
Browse files Browse the repository at this point in the history
  • Loading branch information
@ghiscoding
ghiscoding committed Dec 18, 2021
1 parent e89ba3e commit cfba980
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 45 deletions.
1 change: 0 additions & 1 deletion examples/webpack-demo-vanilla-bundle/src/examples/example02.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { TextExportService } from '@slickgrid-universal/text-export';
import { Slicker, SlickVanillaGridBundle } from '@slickgrid-universal/vanilla-bundle';

import { ExampleGridOptions } from './example-grid-options';
import '../material-styles.scss';
import './example02.scss';

const NB_ITEMS = 500;
Expand Down
1 change: 0 additions & 1 deletion examples/webpack-demo-vanilla-bundle/src/examples/example11.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import * as moment from 'moment-mini';

import { ExampleGridOptions } from './example-grid-options';
import { loadComponent } from 'examples/utilities';
import '../salesforce-styles.scss';
import './example11.scss';

// using external SlickGrid JS libraries
Expand Down
1 change: 0 additions & 1 deletion examples/webpack-demo-vanilla-bundle/src/examples/example12.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import { VanillaForceGridBundle, Slicker } from '@slickgrid-universal/vanilla-fo
import { CompositeEditor, SlickCompositeEditorComponent } from '@slickgrid-universal/composite-editor-component';

import { ExampleGridOptions } from './example-grid-options';
import '../salesforce-styles.scss';
import './example12.scss';

// using external SlickGrid JS libraries
Expand Down
1 change: 0 additions & 1 deletion examples/webpack-demo-vanilla-bundle/src/examples/example14.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { ExcelExportService } from '@slickgrid-universal/excel-export';
import { Slicker, SlickerGridInstance, SlickVanillaGridBundle } from '@slickgrid-universal/vanilla-bundle';

import { ExampleGridOptions } from './example-grid-options';
import '../salesforce-styles.scss';
import './example14.scss';

const NB_ITEMS = 5000;
Expand Down
1 change: 0 additions & 1 deletion examples/webpack-demo-vanilla-bundle/src/examples/example15.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Slicker, SlickVanillaGridBundle } from '@slickgrid-universal/vanilla-bu
import { delay, Observable, of, Subject } from 'rxjs';

import { ExampleGridOptions } from './example-grid-options';
import '../salesforce-styles.scss';
import './example15.scss';

const defaultPageSize = 20;
Expand Down
20 changes: 1 addition & 19 deletions packages/common/src/styles/_variables-theme-material.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ $slick-header-resizable-hover-width: 4px !default;
$slick-header-resizable-hover-border-radius: 8px !default;
$slick-header-resizable-hover-right: 0 !default;
$slick-header-resizable-hover-opacity: 0.4 !default;
$slick-pane-top-border-top: 1px solid #d0d0d0 !default;
$slick-pane-top-border-top: 1px solid #d0d0d0 !default;
$slick-container-border-top: 1px solid #ccc !default;
$slick-container-border-bottom: 1px solid #ccc !default;
$slick-container-border-left: 1px solid #ccc !default;
Expand All @@ -60,12 +60,6 @@ $slick-column-picker-checkbox-icon-checked: url('data:image/svg+
$slick-column-picker-checkbox-icon-unchecked: $slick-column-picker-checkbox-icon-checked !default;
$slick-column-picker-checkbox-width: $slick-icon-width !default;
$slick-column-picker-close-btn-font-size: 23px !default;
// $slick-column-picker-title-font-size: 18px !default;
// $slick-cell-menu-close-btn-margin: -4px 1px 1px 1px !default;
// $slick-cell-menu-icon-margin-right: 6px !default;
// $slick-cell-menu-title-font-size: 18px !default;
// $slick-context-menu-item-font-size: 16px !default;
// $slick-context-menu-icon-font-size: $slick-icon-width !default;
$slick-column-picker-item-font-size: 14px !default;
$slick-column-picker-checkbox-icon-line-height: 16px !default;
$slick-column-picker-checkbox-icon-vertical-align: middle !default;
Expand Down Expand Up @@ -96,15 +90,6 @@ $slick-draggable-group-toggle-expanded-icon: $slick-icon-group-ex
$slick-draggable-group-title-height: 24px !default;
$slick-draggable-group-title-line-height: 24px !default;
$slick-draggable-group-title-vertical-align: top !default;
// $slick-grid-menu-checkbox-size: $slick-column-picker-checkbox-width !default;
// $slick-grid-menu-checkbox-font-weight: normal !default;
// $slick-grid-menu-checkbox-icon-checked: $slick-column-picker-checkbox-icon-checked !default;
// $slick-grid-menu-checkbox-icon-unchecked: $slick-column-picker-checkbox-icon-checked !default;
// $slick-grid-menu-checkbox-width: $slick-column-picker-checkbox-width !default;
// $slick-grid-menu-icon-font-size: $slick-icon-width !default;
// $slick-grid-menu-icon-width: $slick-icon-width !default;
// $slick-grid-menu-icon-top-margin: 8px !default;
// $slick-grid-menu-title-font-size: 18px !default;
$slick-header-button-hidden-margin-right: -6px !default;
$slick-header-button-height: 18px !default;
$slick-header-button-width: 18px !default;
Expand All @@ -116,9 +101,6 @@ $slick-header-menu-button-icon-color: $slick-icon-color !d
$slick-header-menu-button-icon: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" fill="#{encodecolor($slick-header-menu-button-icon-color)}" viewBox="0 0 24 24"><path d="M7.41,8.58L12,13.17L16.59,8.58L18,10L12,16L6,10L7.41,8.58Z"></path></svg>') !default;
$slick-header-menu-button-margin-right: 8px !default;
$slick-header-menu-display: inline-block !default;
// $slick-header-menu-icon-margin-right: 6px !default;
// $slick-header-menu-icon-font-size: $slick-icon-width !default;
// $slick-header-menu-icon-width: $slick-icon-width !default;
$slick-autocomplete-loading-icon-color: $slick-icon-color !default;
$slick-autocomplete-loading-icon: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" fill="#{encodecolor($slick-autocomplete-loading-icon-color)}" viewBox="0 0 24 24"><path d="M16,13V11H21V13H16M14.83,7.76L17.66,4.93L19.07,6.34L16.24,9.17L14.83,7.76M11,16H13V21H11V16M11,3H13V8H11V3M4.93,17.66L7.76,14.83L9.17,16.24L6.34,19.07L4.93,17.66M4.93,6.34L6.34,4.93L9.17,7.76L7.76,9.17L4.93,6.34M8,13H3V11H8V13M19.07,17.66L17.66,19.07L14.83,16.24L16.24,14.83L19.07,17.66Z"></path></svg>') !default;
$slick-autocomplete-loading-icon-width: 22px !default;
Expand Down
21 changes: 0 additions & 21 deletions packages/common/src/styles/_variables-theme-salesforce.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,6 @@ $slick-column-picker-checkbox-icon-checked: url('data:image/sv
$slick-column-picker-checkbox-icon-unchecked: $slick-column-picker-checkbox-icon-checked !default;
$slick-column-picker-checkbox-width: 13px !default;
$slick-column-picker-close-btn-font-size: 23px !default;
// $slick-column-picker-title-font-size: 18px !default;
// $slick-cell-menu-icon-margin-right: 6px !default;
// $slick-cell-menu-close-btn-height: 18px !default;
// $slick-cell-menu-min-width: 75px !default;
// $slick-cell-menu-title-font-size: 18px !default;
// $slick-context-menu-item-font-size: 16px !default;
// $slick-context-menu-icon-font-size: 16px !default;
// $slick-context-menu-icon-margin-right: 5px !default;
$slick-column-picker-item-font-size: 14px !default;
$slick-column-picker-checkbox-icon-line-height: 16px !default;
$slick-column-picker-checkbox-icon-vertical-align: middle !default;
Expand Down Expand Up @@ -118,16 +110,6 @@ $slick-draggable-group-toggle-expanded-icon: $slick-icon-group-
$slick-draggable-group-title-height: 24px !default;
$slick-draggable-group-title-line-height: 24px !default;
$slick-draggable-group-title-vertical-align: top !default;
// $slick-grid-menu-checkbox-size: $slick-column-picker-checkbox-width !default;
// $slick-grid-menu-checkbox-font-weight: normal !default;
// $slick-grid-menu-checkbox-icon-checked: $slick-column-picker-checkbox-icon-checked !default;
// $slick-grid-menu-checkbox-icon-unchecked: $slick-column-picker-checkbox-icon-checked !default;
// $slick-grid-menu-checkbox-margin-right: 5px !default;
// $slick-grid-menu-checkbox-width: $slick-column-picker-checkbox-width !default;
// $slick-grid-menu-close-btn-margin: -2px 2px 1px 1px !default;
// $slick-grid-menu-icon-font-size: 18px !default;
// $slick-grid-menu-icon-width: 18px !default;
// $slick-grid-menu-title-font-size: 18px !default;
$slick-header-button-hidden-margin-right: -6px !default;
$slick-header-button-height: 18px !default;
$slick-header-button-width: 18px !default;
Expand All @@ -137,9 +119,6 @@ $slick-header-menu-button-icon-font-size: 26px !default;
$slick-header-menu-button-icon-color: #706e6b !default;
$slick-header-menu-button-icon: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" fill="#{encodecolor($slick-header-menu-button-icon-color)}" viewBox="0 0 24 24"><path d="M22 8.2l-9.5 9.6c-.3.2-.7.2-1 0L2 8.2c-.2-.3-.2-.7 0-1l1-1c.3-.3.8-.3 1.1 0l7.4 7.5c.3.3.7.3 1 0l7.4-7.5c.3-.2.8-.2 1.1 0l1 1c.2.3.2.7 0 1z"></path></svg>') !default;
$slick-header-menu-button-margin-right: 8px !default;
// $slick-header-menu-icon-margin-right: 6px !default;
// $slick-header-menu-icon-font-size: $slick-icon-width !default;
// $slick-header-menu-icon-width: $slick-icon-width !default;
$slick-autocomplete-loading-icon-color: $slick-icon-color !default;
$slick-autocomplete-loading-icon: url('data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" fill="#{encodecolor($slick-autocomplete-loading-icon-color)}" viewBox="0 0 24 24"><path d="M16,13V11H21V13H16M14.83,7.76L17.66,4.93L19.07,6.34L16.24,9.17L14.83,7.76M11,16H13V21H11V16M11,3H13V8H11V3M4.93,17.66L7.76,14.83L9.17,16.24L6.34,19.07L4.93,17.66M4.93,6.34L6.34,4.93L9.17,7.76L7.76,9.17L4.93,6.34M8,13H3V11H8V13M19.07,17.66L17.66,19.07L14.83,16.24L16.24,14.83L19.07,17.66Z"></path></svg>') !default;
$slick-autocomplete-loading-icon-width: 22px !default;
Expand Down

0 comments on commit cfba980

Please sign in to comment.