fix(editors): make sure appendChild exist before using it to add Editor

ghiscoding · Mar 24, 2020 · 90d4a67 · 90d4a67
1 parent 76b4177
commit 90d4a67
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/packages/common/src/editors/checkboxEditor.ts b/packages/common/src/editors/checkboxEditor.ts
@@ -54,7 +54,10 @@ export class CheckboxEditor implements Editor {
     this._input.title = title;
     this._input.type = 'checkbox';
     this._input.value = 'true';
-    this.args.container.append(this._input);
+    const cellContainer = this.args?.container;
+    if (cellContainer && typeof cellContainer.appendChild === 'function') {
+      cellContainer.appendChild(this._input);
+    }
     this.focus();
 
     // make the checkbox editor act like a regular checkbox that commit the value on click

diff --git a/packages/common/src/editors/floatEditor.ts b/packages/common/src/editors/floatEditor.ts
@@ -63,7 +63,10 @@ export class FloatEditor implements Editor {
     this._input.placeholder = placeholder;
     this._input.title = title;
     this._input.step = this.getInputDecimalSteps();
-    this.args.container.append(this._input);
+    const cellContainer = this.args?.container;
+    if (cellContainer && typeof cellContainer.appendChild === 'function') {
+      cellContainer.appendChild(this._input);
+    }
 
     this._input.onkeydown = ((event: KeyboardEvent) => {
       this._lastInputEvent = event;

diff --git a/packages/common/src/editors/integerEditor.ts b/packages/common/src/editors/integerEditor.ts
@@ -60,7 +60,10 @@ export class IntegerEditor implements Editor {
     this._input.autocomplete = 'off';
     this._input.placeholder = placeholder;
     this._input.title = title;
-    this.args.container.append(this._input);
+    const cellContainer = this.args?.container;
+    if (cellContainer && typeof cellContainer.appendChild === 'function') {
+      cellContainer.appendChild(this._input);
+    }
 
     this._input.onkeydown = ((event: KeyboardEvent) => {
       this._lastInputEvent = event;

diff --git a/packages/common/src/editors/textEditor.ts b/packages/common/src/editors/textEditor.ts
@@ -60,7 +60,10 @@ export class TextEditor implements Editor {
     this._input.autocomplete = 'off';
     this._input.placeholder = placeholder;
     this._input.title = title;
-    this.args.container.append(this._input);
+    const cellContainer = this.args?.container;
+    if (cellContainer && typeof cellContainer.appendChild === 'function') {
+      cellContainer.appendChild(this._input);
+    }
 
     this._input.onkeydown = ((event: KeyboardEvent) => {
       this._lastInputEvent = event;

diff --git a/packages/common/src/global-grid-options.ts b/packages/common/src/global-grid-options.ts
@@ -25,7 +25,7 @@ export const GlobalGridOptions: GridOption = {
   columnPicker: {
     fadeSpeed: 0,
     hideForceFitButton: false,
-    hideSyncResizeButton: true
+    hideSyncResizeButton: true,
   },
   cellMenu: {
     autoAdjustDrop: true,