Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update so that Angular 9+ Ivy engine can better tree shake and remove warnings #277

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Update so that Angular 9+ Ivy engine can better tree shake and remove warnings #277

wants to merge 15 commits into from

Conversation

ernestoulloa
Copy link

  • Removed qs dependency and took the functions from it being used and refactored them into es5 compatibility
  • Changed lodash depency to lodash-es (es5 module)

@coveralls
Copy link

Coverage Status

Coverage decreased (-12.2%) to 79.006% when pulling 1134954 on ernestoulloa:update-4-ivy into 228a35f on ghidoz:master.

@hpawe01 hpawe01 mentioned this pull request Jan 21, 2021
Open
jphillips03 added a commit to ngx-material-dashboard/ngx-material-dashboard that referenced this pull request Mar 6, 2023
@jphillips03
chore: remove external dependency on qs and lodash
b18cb19 
Add utilities to replace qs library based on code included with git pull on
angular2-jsonapi library ghidoz/angular2-jsonapi#277 and
updated to work with latest version of typescript. Also include fixes for id parameter
and test format (removing "data" from single records for base-json expected data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ernestoulloa @coveralls