Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#239 cyclic hasmany #241

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Fix#239 cyclic hasmany #241

merged 2 commits into from
Sep 25, 2019

Conversation

magneticflux-
Copy link
Contributor

Doesn't fix #239 yet, but it demonstrates the issue.

@magneticflux-
Copy link
Contributor Author

@safo6m Would you accept a PR refactoring the project into the standard Angular CLI library format? I think it would help with testing and deployment, and make it easier to update going forwards.

@safo6m
Copy link
Collaborator

safo6m commented Sep 9, 2019

@safo6m Would you accept a PR refactoring the project into the standard Angular CLI library format? I think it would help with testing and deployment, and make it easier to update going forwards.

@magneticflux-
of course, that would be fantastic

@magneticflux- magneticflux- changed the base branch from master to release-v8 September 17, 2019 14:39
@magneticflux- magneticflux- marked this pull request as ready for review September 23, 2019 19:35
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 91.176% when pulling 12ddd70 on magneticflux-:fix#239-cyclic-hasmany into bfd18b5 on ghidoz:release-v8.

@magneticflux-
Copy link
Contributor Author

magneticflux- commented Sep 25, 2019

@safo6m This fixes the issue in my own situation. Can you release another beta with these changes soon?

@safo6m safo6m merged commit 0db958a into ghidoz:release-v8 Sep 25, 2019
@safo6m
Copy link
Collaborator

safo6m commented Sep 25, 2019

@safo6m This fixes the issue in my own situation. Can you release another beta with these changes soon?

v8.2.1-beta released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants