ggml-cuda : update cudaLaunchKernelEx check to 12.0#3829
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit updates the CUDART check to 12.8 instead of the current 11.8. The motivation for this is that currently whisper.cpp CI is failing when building 11.8.0, with the following error: ```console ggml\src\ggml-cuda\common.cuh(1568): error: identifier "cudaLaunchKernelEx" is undefined ``` It looks like cudaLaunchKernelEx was introduced in CUDA 12.0 which would therefor be the reason for this failure. Refs: https://github.com/ggml-org/whisper.cpp/actions/runs/26493577141/job/78016424109?pr=3735#step:11:879
Member
Author
|
It looks like this fixes windows-cublas (Release, x64, ON, ON, 11.8.0). I'm looking into the ggml-ci-mac-vulkan failure. This seems to be caused by missing |
Member
Author
|
Closing this in favor of ggml-org/llama.cpp#23742 which will be available after the next ggml sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the CUDART check to 12.8 instead of the current 11.8.
The motivation for this is that currently whisper.cpp CI is failing when building 11.8.0, with the following error:
ggml\src\ggml-cuda\common.cuh(1568): error: identifier "cudaLaunchKernelEx" is undefinedIt looks like cudaLaunchKernelEx was introduced in CUDA 12.0 which would therefor be the reason for this failure.
Refs: https://github.com/ggml-org/whisper.cpp/actions/runs/26493577141/job/78016424109?pr=3735#step:11:879