Add error handling to graph_compute #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
approved these changes
Jan 3, 2024
viktor-silakov
pushed a commit
to viktor-silakov/whisper_node_mic.cpp
that referenced
this pull request
May 11, 2024
iThalay
pushed a commit
to iThalay/whisper.cpp
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using whisper.cpp in an iOS app and due to GPU execution not being permitted when an iOS app is in the background, we are seeing crashes at https://github.com/ggerganov/whisper.cpp/blob/f9ca90256bf691642407e589db1a36562c461db7/ggml-metal.m#L2385
This PR returns a bool from graph_compute indicating failure instead of asserting false to avoid crashing. Wasn't sure if this was the best way to fix this issue, but it is working for us at least. All backends other than metal currently just return true.
Please let me know if I missed something or if anyone has better ideas for error handling.
Fixes #1670 and #1664