Skip to content

Avoid errors in the face of NaN/Inf timing values in response #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

Avoid errors in the face of NaN/Inf timing values in response #87

merged 1 commit into from
Oct 16, 2025

Conversation

@usrlocalben
Copy link
Contributor

@usrlocalben usrlocalben commented Oct 15, 2025

Closes #86

ggerganov
ggerganov approved these changes Oct 16, 2025
View reviewed changes
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I fixed those in ggml-org/llama.cpp#16501. But I guess it does not hurt to have the changes in llama.vim as well.

@ggerganov ggerganov merged commit 59d3e7a into ggml-org:master Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Server responses with null (NaN, Inf) values for timing may throw

2 participants

@usrlocalben @ggerganov