Skip to content

[SYCL] Fix the accuracy bug of long context length #8642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

[SYCL] Fix the accuracy bug of long context length #8642

merged 1 commit into from
Jul 23, 2024

Conversation

@luoyu-intel
Copy link
Contributor

@github-actions github-actions bot added the SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language label Jul 23, 2024
@luoyu-intel
Copy link
Contributor Author

@qnixsynapse Hi, has this branch fixed your issue?

@qnixsynapse
Copy link
Collaborator

qnixsynapse commented Jul 23, 2024 •
edited
Loading

@luoyu-intel Hi. Sorry for being late. In my initial tests It seems to be working correctly for context way past 1000. (I have tested upto 2500).

This PR is looking good!
Thank you!

@airMeng airMeng merged commit 063d99a into ggml-org:master Jul 23, 2024
@qnixsynapse qnixsynapse mentioned this pull request Jul 23, 2024
Closed
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Jul 27, 2024
@luoyu-intel @arthw
[SYCL] fix scratch size of softmax (ggml-org#8642)
a9c03e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@airMeng airMeng airMeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luoyu-intel @qnixsynapse @airMeng