contrib : clarify PR squashing + module names #8630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Green-Sky
reviewed
Jul 22, 2024
slaren
reviewed
Jul 22, 2024
| # Pull requests (for collaborators) | ||
|
|
||
| - Squash-merge PRs | ||
| - Use the following format for the squashed commit title: `<module> : <commit title> (#<issue_number>)`. For example: `utils : fix typo in utils.py (#1234)` |
There was a problem hiding this comment.
It would be useful to have a list of modules, it's not always very clear what to use as module name.
There was a problem hiding this comment.
Yea, having multiple examples should increase human performance in correctly choosing the module string.
single-shot -> multi-shot :)
There was a problem hiding this comment.
Added a reference to a wiki page with some common modules that we've used so far based on the current git history: https://github.com/ggerganov/llama.cpp/wiki/Modules
ggerganov
force-pushed
the
gg/contributing
branch
from
17b3cf7 to
562a0c9
Compare
ggerganov
changed the title
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 27, 2024
* contrib : clarify PR squashing * contrib : fix typo + add list of modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't clear that the PR squashing should be done upon merging. Also add note for stale PRs