sycl-exp : Revert "Minor arithmetic improvement to mmvq wrapper kernel (#7172)" #7980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8c570c9.
OuadiElfarouki
approved these changes
Jun 17, 2024
Contributor
OuadiElfarouki
left a comment
OuadiElfarouki
left a comment
There was a problem hiding this comment.
Thanks for spotting that!
github-actions
bot
added
the
SYCL
Alcpz
pushed a commit
to Alcpz/llama.cpp
that referenced
this pull request
Jun 20, 2024
ggml-org#7172)" (ggml-org#7980) * Revert "Minor arithmetic improvement to mmvq wrapper kernel (ggml-org#7172)" This reverts commit 8c570c9. * Update ggml-sycl.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit 8c570c9, which was found to introduce a MatMul bug. Corresponding PR for
mainwill be raised in due course.