Skip to content

Fix for temp == 0 issue #684 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fabio3rs wants to merge 2 commits into from
+7 −0
Closed

Fix for temp == 0 issue #684 #689

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3300247
Fix for temp == 0
Fabio3rs Apr 1, 2023
9523d72
top_k = 1 since it is an integer
Fabio3rs Apr 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llama.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "ggml.h"

#include <cinttypes>
#include <float.h>
#include <fstream>
#include <random>
#include <map>
Expand Down Expand Up @@ -1757,6 +1758,12 @@ llama_token llama_sample_top_p_top_k(
// TODO: avoid this ...
const auto last_n_tokens = std::vector<llama_token>(last_n_tokens_data, last_n_tokens_data + last_n_tokens_size);

if (std::abs(temp) < FLT_EPSILON) {
temp = 0.8f;
top_k = 1.0f;
Comment thread
Fabio3rs marked this conversation as resolved.
Outdated
top_p = 0.0f;
}

result = llama_sample_top_p_top_k(
*ctx,
last_n_tokens,
Expand Down