Skip to content

convert : fix set_vocab_sentencepiece #6866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2024
Merged

convert : fix set_vocab_sentencepiece #6866

merged 3 commits into from
May 18, 2024

Conversation

ggerganov
Copy link
Member

Using the same logic as in #6852 for _set_vocab_sentencepiece()

@ggerganov
Copy link
Member Author

ggerganov commented Apr 24, 2024 •
edited
Loading

@JustinLin610 Can you give this PR a try using codeqwen and confirm that it continues to convert correctly?

@ggerganov ggerganov added the need feedback Testing and feedback with results are needed label Apr 24, 2024
@ggerganov ggerganov requested a review from cebtenzzre April 29, 2024 14:27
@ggerganov
Copy link
Member Author

This change should be good, right?

@compilade compilade mentioned this pull request May 3, 2024
Merged
@mofosyne mofosyne added Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix bugfix fixes an issue or bug labels May 9, 2024
ggerganov
ggerganov commented May 10, 2024
View reviewed changes
mofosyne
mofosyne approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@mofosyne mofosyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked that the logic checks out.

Looks like a refactoring kind of bugfix? If so then let's merge it in.

@mofosyne mofosyne added the merge ready indicates that this may be ready to merge soon and is just holding out in case of objections label May 18, 2024
@ggerganov ggerganov merged commit b49a13d into master May 18, 2024
@ggerganov ggerganov deleted the gg/fix-spm-vocab-convert branch May 18, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cebtenzzre cebtenzzre Awaiting requested review from cebtenzzre

1 more reviewer

@mofosyne mofosyne mofosyne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfix fixes an issue or bug merge ready indicates that this may be ready to merge soon and is just holding out in case of objections need feedback Testing and feedback with results are needed Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggerganov @mofosyne