fix memcpy() crash, add missed cmd in guide, fix softmax#6622
fix memcpy() crash, add missed cmd in guide, fix softmax#6622NeoZhangJianyu merged 8 commits intoggml-org:masterfrom
Conversation
|
@slaren I have tried a solution to return support_mmap by backend in callback function. |
|
This is not ok, if you need a workaround add a |
|
@slaren |
|
If the driver crashes when it receives an address from |
|
driver is not crash. |
|
memcpy the ptr you get in the |
|
host -> host -> device. this solution should be OK. |
|
@slaren Yes, it works well. |
ggml-sycl.cpp
Outdated
| std::exit(1); | ||
| } | ||
|
|
||
| class host_buffer { |
There was a problem hiding this comment.
approved after this is removed
There was a problem hiding this comment.
yes, remove host_buffer. use malloc/free for thread safe and better performance.
…l-org#6622)" This reverts commit de17e3f.
why the source ptr provided by mmap is unavailable? I'd like to reproduce this issue in my local dev, could you help provide a quick guide for this: whether I only need to read the docs/backend/SYCL.md? |
|
your explanation in #12734 is very clear, thanks so much. |
fix it by use host buf.