Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metal : try to unify mul_mv_id kernels #6556

Merged
merged 1 commit into from
Apr 12, 2024
Merged

metal : try to unify mul_mv_id kernels #6556

merged 1 commit into from
Apr 12, 2024

Conversation

slaren
Copy link
Member

@slaren slaren commented Apr 8, 2024 •
edited
Loading

Prerequisite to #6505

@slaren slaren force-pushed the sl/metal-mvid-tpl branch from a76a3bb to d40b626 Compare April 12, 2024 15:41
@slaren slaren force-pushed the sl/metal-mvid-tpl branch from d40b626 to 39d4427 Compare April 12, 2024 15:41
@slaren slaren marked this pull request as ready for review April 12, 2024 15:42
@slaren slaren requested a review from ggerganov April 12, 2024 15:42
@slaren
Copy link
Member Author

slaren commented Apr 12, 2024

@ggerganov these changes add a dummy shared_values parameter to the all the mul_mv kernels, regardless of if they use shared memory, to reduce the number of variations.

ggerganov
ggerganov approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@slaren
Copy link
Member Author

slaren commented Apr 12, 2024

It seems that the ggml-100-m1 runner is not working at the moment. It is also missing from the master runs.

@slaren slaren merged commit fbbc030 into master Apr 12, 2024
44 of 55 checks passed
@slaren slaren deleted the sl/metal-mvid-tpl branch April 12, 2024 16:13
@ggerganov
Copy link
Member

Yeah, the machine is down for some reason - will resolve next week

@ggerganov
Copy link
Member

ggml-100-m1 is up again

tybalex pushed a commit to rubra-ai/tools.cpp that referenced this pull request Apr 17, 2024
@slaren @tybalex
metal : unify mul_mv_id kernels (ggml-org#6556)
961e1ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggerganov ggerganov ggerganov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaren @ggerganov