Skip to content

server: monitoring - add /metrics prometheus compatible endpoint #5708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2024
Merged

server: monitoring - add /metrics prometheus compatible endpoint #5708

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b8322be
server: monitoring - add /metrics prometheus compatible endpoint
phymbert Feb 25, 2024
7b29648
server: concurrency issue, when 2 task are waiting for results, only …
phymbert Feb 25, 2024
542f42a
server: metrics - move to a dedicated struct
phymbert Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/server/utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ struct llama_server_response {
{
LOG_VERBOSE("queue_results.push_back", {});
queue_results.push_back(result);
condition_results.notify_one();
condition_results.notify_all();
Copy link
Collaborator Author

@phymbert phymbert Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggerganov @ngxson I was looking for a while why health/metrics/slots endpoints were blocking when a completion request is processing: only one caller thread was notified. Please confirm my fix.

Copy link
Collaborator

@ngxson ngxson Feb 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing, that's LGTM. Seems like this is the root cause of many stability issues of concurrent requests.

Copy link
Member

@ggerganov ggerganov Feb 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, notify_all is correct

return;
}
}
Expand Down