Fix logits_all parameter being ignored #4390
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`batch.logits` is always true since the new batch API mallocs it. This made the other control flows dead code. I am unsure what the last else statement was intended to do, and removed it because it has been dead code for a while anyway.
Not true. llama_eval and llama_batch_get_one still exist and set it to nullptr. logits_all should not be used with the new batch API - instead, set all of batch.logits to true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batch.logitsis always true since the new batch API mallocs it. This made the other control flows dead code.I am unsure what the last else statement was intended to do, and removed it because it has been dead code for a while anyway.