flake.nix: fix for rocm 5.7#3853
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Oct 31, 2023
Merged
Conversation
Green-Sky
approved these changes
Oct 30, 2023
Collaborator
Green-Sky
left a comment
Green-Sky
left a comment
There was a problem hiding this comment.
I dont have an amd device to test this with, but the nix changes look alright.
Madouura
reviewed
Nov 20, 2023
| # Build all targets supported by rocBLAS. When updating search for TARGET_LIST_ROCM | ||
| # in github.com/ROCmSoftwarePlatform/rocBLAS/blob/develop/CMakeLists.txt | ||
| # and select the line that matches the current nixpkgs version of rocBLAS. | ||
| "-DAMDGPU_TARGETS=gfx803;gfx900;gfx906:xnack-;gfx908:xnack-;gfx90a:xnack+;gfx90a:xnack-;gfx940;gfx941;gfx942;gfx1010;gfx1012;gfx1030;gfx1100;gfx1101;gfx1102" |
There was a problem hiding this comment.
The nixpkgs rocblas derivation should build everything by default, is this necessary?
There was a problem hiding this comment.
Ah. I misread. I thought this was rebuilding rocblas for some reason.
olexiyb
pushed a commit
to Sanctum-AI/llama.cpp
that referenced
this pull request
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NixOS/nixpkgs#258328 moved all the rocm packages to rocmPackages, this has been fixed.
Also because hipcc targets autodetection doesn't work with nix sandbox, now every rocblas target is built by default, compiling all targets increases build times but guarantees llama.cpp to work with every rocm supported gpu, until now only some random target where built.
This fixes #3320 when using nix.