Fixed GBNF grammar generation for empty object schemas - #28279
Merged
Conversation
|
Hi @SergeySklyarov, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
SergeySklyarov
force-pushed
the
fix-empty-object-grammar
branch
from
September 2, 2026 23:40
e101e16 to
f580855
Compare
SergeySklyarov
changed the title
aldehir
reviewed
Sep 2, 2026
SergeySklyarov
force-pushed
the
fix-empty-object-grammar
branch
from
September 2, 2026 23:56
f580855 to
1c142af
Compare
SergeySklyarov
force-pushed
the
fix-empty-object-grammar
branch
from
September 3, 2026 08:36
1c142af to
1d41b3b
Compare
pwilkin
approved these changes
Sep 3, 2026
aldehir
approved these changes
Sep 3, 2026
fewtarius
pushed a commit
to fewtarius/CachyLLama
that referenced
this pull request
Sep 5, 2026
agentdavo
pushed a commit
to agentdavo/llama.cpp
that referenced
this pull request
Sep 6, 2026
…emas (ggml-org#28279) (cherry picked from commit c5a5535)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed GBNF grammar generation for empty object schemas
Schemas without properties were producing consecutive spaces in the generated GBNF grammar, causing parsing failures. Empty object schemas now output a single space instead. This fix has been validated locally with a new unit test for
{ "properties": {} }.