kv-cells : scan the flat pos array instead of walking the used std::set - #28128
Closed
abdel-darwish-27 wants to merge 1 commit into
Closed
kv-cells : scan the flat pos array instead of walking the used std::set#28128abdel-darwish-27 wants to merge 1 commit into
abdel-darwish-27 wants to merge 1 commit into
Conversation
|
Hi @abdel-darwish-27, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This was referenced Sep 1, 2026
The kv cache token lookup was walking a std::set every token which showed up as ~17% of cpu at long context. Changed it to scan the flat pos array instead, same cells same order. Decode at 130k went 17 to 19.7 tok/s, outputs identical.
abdel-darwish-27
force-pushed
the
kv-cells-token-scan
branch
from
September 1, 2026 01:38
465a2e2 to
8d9c719
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The kv cache token lookup was walking a std::set every token which showed up as ~17% of cpu at long context. Changed it to scan the flat pos array instead, same cells same order. Decode at 130k went 17 to 19.7 tok/s, outputs identical.
Requirements