Skip to content

fix pre-rdma macOS versions - #27815

Merged
ggerganov merged 1 commit into
ggml-org:masterfrom
ryan5rdx:fix-pre-rdma-mac-os
Aug 30, 2026
Merged

fix pre-rdma macOS versions#27815
ggerganov merged 1 commit into
ggml-org:masterfrom
ryan5rdx:fix-pre-rdma-mac-os

Conversation

@ryan5rdx

Copy link
Copy Markdown
Contributor

Overview

My rdma transport changes appear to have broken pre-rdma mac os versions at runtime, now on systems without librdma I think it should gracefully fallback.

Additional information

see: #26421 (comment)

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Yes - used an llm to fix this. I don't have a pre-rdma machine to test on but it was able to similate a missing librdma env and build + run.

@github-actions github-actions Bot added the ggml changes relating to the ggml tensor library for machine learning label Aug 27, 2026
@ryan5rdx
ryan5rdx marked this pull request as ready for review August 27, 2026 17:00
@ryan5rdx
ryan5rdx requested a review from a team as a code owner August 27, 2026 17:00
@ryan5rdx

Copy link
Copy Markdown
Contributor Author

@rgerganov if you could take a look, a regression that breaks < tahoe(?) macOS versions

@ryan5rdx

Copy link
Copy Markdown
Contributor Author

verified on an old macOS version here: #26421 (comment)

@taronaeo taronaeo added the merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge. label Aug 29, 2026
@ggerganov
ggerganov merged commit 2bf0415 into ggml-org:master Aug 30, 2026
32 of 35 checks passed
jbooth pushed a commit to jbooth/llama.cpp that referenced this pull request Aug 30, 2026
@srigi

srigi commented Sep 2, 2026

Copy link
Copy Markdown

Thank you gentlemen for this fix. llama.cpp working on Sonoma while it is supported by Apple is a great signal to localLLM community.

fewtarius pushed a commit to fewtarius/CachyLLama that referenced this pull request Sep 5, 2026
@EAddario EAddario mentioned this pull request Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning merge ready A maintainer can use this label to indicate that they consider the changes final and ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants