ui: Update Dialog component styling - #27743
Merged
Merged
Conversation
allozaur
changed the title
allozaur
marked this pull request as ready for review
August 26, 2026 14:05
allozaur
requested review from
ServeurpersoCom and
ggerganov
and
a lite review from Copilot
August 26, 2026 14:05
Contributor
There was a problem hiding this comment.
Pull request overview
UI-focused update to the shared Dialog components to support improved layout/styling for upcoming UI changes, including moving the close affordance into a sticky header and refining dialog sizing behavior.
Changes:
- Add optional sticky header close button support via
Dialog.Header(withshowCloseButtonprop). - Adjust
Dialog.Contentsizing classes and change its defaultshowCloseButtontofalse. - Update Mermaid preview dialog to explicitly show a close button.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/ui/src/lib/components/ui/dialog/dialog-header.svelte | Makes the header sticky and adds an optional close button inside the header. |
| tools/ui/src/lib/components/ui/dialog/dialog-content.svelte | Refines sizing classes and changes default close button behavior (now off by default). |
| tools/ui/src/lib/components/ui/dialog/dialog-close.svelte | Adds a z-index style rule for dialog close elements (currently selector mismatch). |
| tools/ui/src/lib/components/app/dialogs/DialogMermaidPreview.svelte | Enables the close button for the Mermaid preview dialog content. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
allozaur
force-pushed
the
allozaur/feat/chat-form-actions/base-dialog
branch
from
August 26, 2026 15:37
6c26be3 to
a76cd9f
Compare
ggerganov
approved these changes
Aug 26, 2026
ServeurpersoCom
approved these changes
Aug 26, 2026
therealkenc
pushed a commit
to therealkenc/llama.cpp
that referenced
this pull request
Aug 26, 2026
* feat(ui): make base dialog responsive and support sticky headers * ui: move dialog close button to the sticky header Assisted-by: pi * chore: Formatting & linting
ppenatra
pushed a commit
to ppenatra/llama.cpp
that referenced
this pull request
Aug 27, 2026
* feat(ui): make base dialog responsive and support sticky headers * ui: move dialog close button to the sticky header Assisted-by: pi * chore: Formatting & linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Few UI styling improvements for further UI updates.
Requirements