ggml : fix ggml_clamp - #27644
Merged
Merged
Conversation
Member
|
Should it not be added to this too? llama.cpp/ggml/src/ggml-alloc.c Lines 21 to 23 in c060ca9 |
CISC
approved these changes
Aug 24, 2026
therealkenc
pushed a commit
to therealkenc/llama.cpp
that referenced
this pull request
Aug 24, 2026
* ggml : fix ggml_clamp * cont : update ggml-alloc
1 task
3 tasks
ravel7524
pushed a commit
to ravel7524/llama.cpp
that referenced
this pull request
Aug 30, 2026
* ggml : fix ggml_clamp * cont : update ggml-alloc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cont ggml-org/ggml#145
Fix failing test https://github.com/ggml-org/llama.cpp/actions/runs/32657742369/job/97239065076#step:5:12415. The problem is that the first op in the graph split (
GGML_OP_CLAMP) ends up being inplace (due to legacy) on the CI Apple runners (due to limited op support):Requirements