webgpu : fix handling of infinity values during ARGSORT and TOP_K - #27538
Merged
ggerganov merged 3 commits intoAug 25, 2026
Conversation
Contributor
Author
|
I noticed that WebGPU CI fails due to: error (unrelated to this PR), so I tried to fix it in #27545 |
ggerganov
approved these changes
Aug 24, 2026
Contributor
Author
|
Testing: apply the patch below in master: with this PR: |
Member
|
@ggml-org/ggml-webgpu I'll fast-track this PR since I would like to stabilize the CI - there are 4 webgpus jobs currently failing. |
1 task
thecodacus
pushed a commit
to thecodacus/llama.cpp
that referenced
this pull request
Sep 7, 2026
…ml-org#27538) Co-authored-by: Stanisław Szymczyk <sszymczy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces EXTREME_VALUE-based logic in WebGPU ARGSORT shader with more complex condition that compares indices to avoid improper handling of ±infinity values during TOP_K and ARGSORT.
Performance of fixed shader is slightly lower (~5% on my rig).
Requirements