vulkan: combine duplicated fastdiv functions, rename the one optimizing small divs - #27526
Merged
Conversation
github-actions
Bot
added
Vulkan
Contributor
|
I suppose this needs to be rebased for #26686 ? |
jeffbolznv
force-pushed
the
fastdiv_cleanup
branch
from
August 28, 2026 15:38
018cd40 to
e3b3608
Compare
Contributor
Author
|
Rebased and removed the new copy of fastdiv. |
0cc4m
approved these changes
Aug 28, 2026
0cc4m
added
the
merge ready
fewtarius
pushed a commit
to fewtarius/CachyLLama
that referenced
this pull request
Sep 5, 2026
…ng small divs (ggml-org#27526) * vulkan: combine duplicated fastdiv functions, rename the one optimizing small divs * remove one more fastdiv
thecodacus
pushed a commit
to thecodacus/llama.cpp
that referenced
this pull request
Sep 7, 2026
…ng small divs (ggml-org#27526) * vulkan: combine duplicated fastdiv functions, rename the one optimizing small divs * remove one more fastdiv
Githab-capibara
added a commit
to Githab-capibara/llama.cpp
that referenced
this pull request
Sep 10, 2026
…ng small divs (ggml-org#27526) * vulkan: combine duplicated fastdiv functions, rename the one optimizing small divs * remove one more fastdiv
zbrad
pushed a commit
to zbrad/llama.cpp
that referenced
this pull request
Sep 10, 2026
…ng small divs (ggml-org#27526) * vulkan: combine duplicated fastdiv functions, rename the one optimizing small divs * remove one more fastdiv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We had copy/pasted a few copies of this function due to a naming conflict. Rename, and have one copy of each fastdiv optimization.
Requirements