add hardware fp16_to_fp32 - #27452
Open
lexasub wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
ggml
|
Hi @lexasub, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
Contributor
Author
|
@slaren review pls, ok? |
lexasub
commented
Aug 20, 2026
| udata->embd.clear(); | ||
| udata->embd.reserve(n_embd_all); | ||
| } else { | ||
| udata->embd.resize(n_embd_all); // fill all size..new_size elems by 0.0f |
Contributor
Author
There was a problem hiding this comment.
guaranted save prev code logic - always alloc n_embd_all and fill 0.0f when batch.embd doesn't present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Small changes - remove wasting time for fill vector, add hardware fp16_to_fp32 (small change, compiler will optimize dequantize_row_q4_0 better)
Additional information
Extracted from #27396 for fast review and merge small changes
Requirements