ggml: support ggml_rope_set_offset on opencl, sycl, wgpu, hexagon - #27345
Merged
Conversation
github-actions
Bot
added
ggml
ngxson
force-pushed
the
xsn/ggml_rope_off_rest
branch
from
August 19, 2026 12:09
ada83e6 to
2dbbb34
Compare
max-krasnyansky
approved these changes
Aug 20, 2026
max-krasnyansky
left a comment
max-krasnyansky
left a comment
Member
There was a problem hiding this comment.
hexagon changes look good to me
yomaytk
approved these changes
Aug 20, 2026
yomaytk
left a comment
yomaytk
left a comment
Member
There was a problem hiding this comment.
webgpu changes looks good to me.
arthw
approved these changes
Aug 20, 2026
arthw
left a comment
arthw
left a comment
Contributor
There was a problem hiding this comment.
It's OK for SYCL backend.
All related UT cases (ROPE,ROPE_BACK) are passed.
Thank you!
Collaborator
Author
|
thanks everyone, this unblocked #27382 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Ref #27120
Pretty much mechanical change, same logic copied to other backends
Requirements