ci : bundle HIP runtime DLLs with Windows ROCm release by slojosic-amd · Pull Request #26973 · ggml-org/llama.cpp

slojosic-amd · 2026-08-12T14:02:59Z

Overview

Copy amdhip64_7.dll , rocm_kpack.dll and amd_comgr.dll next to the llama.cpp binaries so the correct HIP runtime loads over the driver's copy in System32. Fixes #26929.

Requirements

I have read and agree with the contributing guidelines
AI usage disclosure: YES: I used AI to help me to write the comment section and to better organize the PowerShell copy logic

slojosic-amd · 2026-08-12T14:05:12Z

@superm1 @CISC @IMbackK

IMbackK · 2026-08-12T14:07:55Z

what are the compatibility guarantees between the kernel driver and the runtime on windows?

dennyiriawan · 2026-08-12T15:35:27Z

The plan is to maintain backward compatibility between the kernel driver and runtime interfaces on Windows.

slojosic-amd · 2026-08-26T08:00:03Z

@IMbackK @CISC can we proceed with bundling HIP DLLs or you prefer other solution, something like this: ROCm/TheRock#7143

For more context please check: https://github.com/ScottTodd/rocm-workspace/blob/main/reviews/pr7143-review-packet/02-windows-dll-loading-and-rocm.md

CISC

Please show a successful Release job run.

Copy amdhip64_7 and rocm_kpack next to the binaries so the correct HIP runtime loads over the driver's copy in System32. Fixes ggml-org#26929.

…rg/llama.cpp/pull/27753/changes#r3869441981

… in build\bin\Release; single-config Unix Makefiles would put it in build\bin

…windows jobs

slojosic-amd · 2026-08-27T15:13:53Z

Please show a successful Release job run.

https://github.com/slojosic-amd/llama.cpp/actions/runs/33083575827/job/98558818248

This reverts commit 6742e7e. The upstream step (PR ggml-org#26973) does not fix what our artifact is missing. It bundles the HIP runtime -- amdhip64_7.dll, rocm_kpack.dll, amd_comgr.dll -- but an unpacked f711 artifact still reports no device, because the missing pieces are rocBLAS/hipBLASLt and their Tensile kernel directories. Verified on b10665: --list-devices printed "(none)" with the bundled DLLs present, and still printed "(none)" with them moved aside. We fill those in with patch-rocm-runtime.ps1 from a single reference tree (b10400) so rocBLAS stays constant across measured arms, which also means the bundled DLLs must be kept out of the way to avoid a version mismatch. They only cost ~140 MB per zip. Binaries are unaffected -- this only changes artifact packaging. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014sv3jRGzvPZZpr1uFQegyb

Update the fork description for the current production branch (f711-rdna-b10665-chatfix, rebased onto upstream b10665) and document the rebase procedure the stack is held to: which commits were dropped, the one conflict that needed a real merge (rope.cu), and the three gates that follow a hand-written merge. Also record why the CI artifact still needs the ROCm runtime patched in, and why upstream PR ggml-org#26973 does not replace that step. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014sv3jRGzvPZZpr1uFQegyb

slojosic-amd · 2026-08-28T12:37:54Z

@IMbackK @CISC @taronaeo @superm1 @dennyiriawan thank you for your review and feedback.

There is one more very important thing to mention: users still have to install appropriate ROCm 7.14/10.0 build and to add ROCM_BIN path to system's PATH because hipblas/rocblas/hipblaslt dlls and kernel files are not bundled with llama.cpp binaries.

Mandatory steps (please note that #27803 has to be merged first in order to use ROCm 10.0 install instructions and also example links used here are for gfx1151 (Strix Halo) but users should adapt commands to match their GPU target):

Windows tarball instalation: https://rocm.docs.amd.com/en/latest/install/rocm.html?fam=ryzen&w=compute&gpu=amd-ryzen-ai-max-pro-395&gfx=gfx1151&os=windows&windows-ver=11&i=tar

Post-installation: https://rocm.docs.amd.com/en/latest/install/rocm.html?fam=ryzen&w=compute&gpu=amd-ryzen-ai-max-pro-395&gfx=gfx1151&os=windows&windows-ver=11&i=tar#post-installation

On Ubuntu, similar steps are mandatory:

Users should ensure that they don't have some legacy ROCm (<= ROCm 7.2) already installed on their machine under /opt/rocm
https://rocm.docs.amd.com/en/latest/install/rocm.html?fam=ryzen&w=compute&gpu=amd-ryzen-ai-max-pro-395&gfx=gfx1151&os=ubuntu&i=tar&ubuntu-ver=26.04#install-rocm
https://rocm.docs.amd.com/en/latest/install/rocm.html?fam=ryzen&w=compute&gpu=amd-ryzen-ai-max-pro-395&gfx=gfx1151&os=ubuntu&i=tar&ubuntu-ver=26.04#post-installation

If ROCm installation and post-installation steps are handled correctly, these (or similar) issues should be resolved:

superm1 · 2026-08-28T13:43:18Z

Just a thought - what about if we had a Powershell script that we distributed with the artifact to help do this for people and the guidance is to launch llama.cpp with the Powershell script?

Also - if we do this with a script, I doubt that those variables need to be set as admin. The entire thing should be doable as a user. Basically these steps in the script:

Check for %USERPROFILE%\TheRock
If missing, wget/curl and extract there.
Set up env variables.
Launch llama-server.

The script could then be treated as a llama.cpp wrapper. Any arguments passed to it could be passed directly to llama-server.

Copy amdhip64_7, amd_comgr and rocm_kpack next to the binaries so the correct HIP runtime loads over the driver's copy in System32. Fixes ggml-org#26929.

slojosic-amd requested a review from a team as a code owner August 12, 2026 14:03

This comment was marked as resolved.

Sign in to view

ggml-gh-bot Bot added the draft PR will be changed to draft by github-actions bot label Aug 12, 2026

github-actions Bot marked this pull request as draft August 12, 2026 15:09

github-actions Bot removed the draft PR will be changed to draft by github-actions bot label Aug 12, 2026

ahoplock mentioned this pull request Aug 12, 2026

Misc. bug: Pre-built ROCm Windows binary crashes with "cudaMemGetInfo failed" #26963

Open

github-actions Bot added the devops improvements to build systems and github actions label Aug 12, 2026

slojosic-amd marked this pull request as ready for review August 12, 2026 18:42

CISC approved these changes Aug 26, 2026

View reviewed changes

IMbackK self-assigned this Aug 26, 2026

IMbackK added the need feedback Testing and feedback with results are needed label Aug 26, 2026

harkgill-amd mentioned this pull request Aug 26, 2026

ci : build only the ggml-hip backend for windows-rocm release #27753

Merged

superm1 approved these changes Aug 26, 2026

View reviewed changes

slojosic-amd added 2 commits August 26, 2026 22:19

ci : bundle HIP runtime DLLs with Windows ROCm release

13b8b85

Copy amdhip64_7 and rocm_kpack next to the binaries so the correct HIP runtime loads over the driver's copy in System32. Fixes ggml-org#26929.

ci : also bundle amd_comgr with HIP runtime DLLs

99aeb1a

slojosic-amd force-pushed the slojosic-amd/fix-rocm7.14-packaging branch from f9aefd2 to 99aeb1a Compare August 26, 2026 20:21

slojosic-amd and others added 3 commits August 27, 2026 15:05

Update Destination path to be alligned with https://github.com/ggml-o…

53bd6d8

…rg/llama.cpp/pull/27753/changes#r3869441981

Use Ninja Multi-Config (like windows-cuda/sycl) so build output lands…

95c1402

… in build\bin\Release; single-config Unix Makefiles would put it in build\bin

Install Ninja and update CMake build command to match style of other …

5b7e728

…windows jobs

CISC approved these changes Aug 27, 2026

View reviewed changes

taronaeo approved these changes Aug 27, 2026

View reviewed changes

IMbackK merged commit 6fdd0ac into ggml-org:master Aug 27, 2026
3 checks passed

Navigation Menu

Uh oh!

ci : bundle HIP runtime DLLs with Windows ROCm release - #26973

ci : bundle HIP runtime DLLs with Windows ROCm release#26973
IMbackK merged 5 commits into
ggml-org:masterfrom
slojosic-amd:slojosic-amd/fix-rocm7.14-packaging

slojosic-amd commented Aug 12, 2026 •

edited

Loading

Uh oh!

slojosic-amd commented Aug 12, 2026

Uh oh!

IMbackK commented Aug 12, 2026

Uh oh!

This comment was marked as resolved.

dennyiriawan commented Aug 12, 2026

Uh oh!

slojosic-amd commented Aug 26, 2026

Uh oh!

CISC left a comment

Uh oh!

slojosic-amd commented Aug 27, 2026

Uh oh!

Uh oh!

slojosic-amd commented Aug 28, 2026 •

edited

Loading

Uh oh!

superm1 commented Aug 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

slojosic-amd commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Requirements

Uh oh!

slojosic-amd commented Aug 12, 2026

Uh oh!

IMbackK commented Aug 12, 2026

Uh oh!

This comment was marked as resolved.

dennyiriawan commented Aug 12, 2026

Uh oh!

slojosic-amd commented Aug 26, 2026

Uh oh!

CISC left a comment

Choose a reason for hiding this comment

Uh oh!

slojosic-amd commented Aug 27, 2026

Uh oh!

Uh oh!

slojosic-amd commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

superm1 commented Aug 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

slojosic-amd commented Aug 12, 2026 •

edited

Loading

slojosic-amd commented Aug 28, 2026 •

edited

Loading

superm1 commented Aug 28, 2026 •

edited

Loading