common: migrate the deprecated --mmap/--no-mmap to --load-mode - #26934
Conversation
Replace the deprecated --mmap, --no-mmap, --mlock, and --direct-io flags with the unified --load-mode argument across scripts, examples, and documentation. Internal warning message and env var docs updated accordingly. Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
|
Hi @fboudra, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
taronaeo
left a comment
There was a problem hiding this comment.
Thanks! For docs that specified --mmap, by right they should default to --load-mode mmap instead of auto to prevent unwanted behaviour.
The auto mode is relatively new and I don't know if the results will be different from how the original docs wanted it to be.
arthw
left a comment
There was a problem hiding this comment.
It's OK to SYCL backend.
I verified it and it's passed.
Thank you!
The PR is large but should be easy to review with usually a one-liner per file modified. |
I had myself the same question. Following #26081 , it seemed safe to map |
|
For now |
|
I'm seeing this CI error: https://github.com/ggml-org/llama.cpp/actions/runs/31545705425/job/94473177972?pr=26934#step:9:12948 I don't think it is caused by this PR, but I'm taking a deeper look to confirm before merging. |
…org#26934) Replace the deprecated --mmap, --no-mmap, --mlock, and --direct-io flags with the unified --load-mode argument across scripts, examples, and documentation. Internal warning message and env var docs updated accordingly. Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
…org#26934) Replace the deprecated --mmap, --no-mmap, --mlock, and --direct-io flags with the unified --load-mode argument across scripts, examples, and documentation. Internal warning message and env var docs updated accordingly. Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
Overview
Migrate the deprecated
--mmap,--no-mmap,--mlock, and--direct-ioflags to the unified--load-modeargument across scripts, examples, and documentation.Additional information
llama-model-loader.cppRequirements