Skip to content

Jimwu.fix backend sampler hip multi output #26878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 3 commits into from
Aug 11, 2026
Merged

Jimwu.fix backend sampler hip multi output #26878

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40ab1f5
test-backend-sampler: skip multi_output_sampling_chain on HIP
Aug 11, 2026
67ab50e
ci: keep gpu-rocm logs in a per-run dir keyed by GitHub run id
Aug 11, 2026
5a13ad3
test-backend-sampler: also skip multi_output_cpu on HIP
Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ci/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ mkdir -p "$2"
OUT=$(realpath "$1")
MNT=$(realpath "$2")

# gpu-rocm self-hosted runner can't upload logs to blob; keep each run's logs in
# their own dir keyed by the GitHub run id so an Actions run URL maps to its logs.
if [ -n "${GG_BUILD_ROCM}" ] && [ -n "${GITHUB_RUN_ID}" ]; then
OUT="$OUT/run-${GITHUB_RUN_ID}-${GITHUB_RUN_ATTEMPT:-1}"
mkdir -p "$OUT"
echo "ci results dir: $OUT"
fi

rm -f $OUT/*.log
rm -f $OUT/*.exit
rm -f $OUT/*.md
Expand Down
3 changes: 2 additions & 1 deletion tests/test-backend-sampler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2105,7 +2105,8 @@ static std::vector<const backend_test_case *> collect_tests_to_run(const std::st
#ifdef GGML_USE_HIP
// TODO: remove this when https://github.com/ggml-org/llama.cpp/pull/26592 is merged
if (test.name == "penalties" || test.name == "set_sampler" ||
test.name == "mixed" || test.name == "top_p") {
test.name == "mixed" || test.name == "top_p" ||
test.name == "multi_output_sampling_chain") {
fprintf(stderr, "Skipping test '%s' on HIP backend (no backend TOP_K support)\n", test.name.c_str());
continue;
}
Expand Down
Loading