SYCL: Refactor GGML_SYCL_ENABLE_MKL_FA to global var - #26863
Merged
Titaniumtown merged 1 commit intoSep 4, 2026
Conversation
github-actions
Bot
added
documentation
johnkarlhill
marked this pull request as ready for review
August 10, 2026 22:12
NeoZhangJianyu
approved these changes
Aug 11, 2026
NeoZhangJianyu
left a comment
NeoZhangJianyu
left a comment
Contributor
There was a problem hiding this comment.
It's good job!
Thank you!
arthw
approved these changes
Aug 11, 2026
johnkarlhill
force-pushed
the
sycl-mkl-enable-refactor
branch
from
August 11, 2026 17:20
55bb5c2 to
8e43f86
Compare
arthw
added
the
merge ready
johnkarlhill
force-pushed
the
sycl-mkl-enable-refactor
branch
from
August 15, 2026 19:33
8e43f86 to
c8df63b
Compare
Contributor
Author
I checked this morning and this needed to be rebased onto the updated #26689. The old branch still carried the GGML_SYCL_FA_DECODE_KERNEL commits that were removed from #26689, so I re-applied just the mkl refactor as a single commit on top of the new head. No other changes. |
Contributor
|
@johnkarlhill |
Contributor
Author
ggerganov
removed
the
merge ready
Contributor
|
Sorry, I forgot to continue reviewing this PR. |
arthw
approved these changes
Sep 2, 2026
Contributor
|
#26689 is merged. |
johnkarlhill
force-pushed
the
sycl-mkl-enable-refactor
branch
from
September 2, 2026 12:40
c8df63b to
29a32b1
Compare
Contributor
Author
Just rebased so this PR is as clean as a whistle :-) |
arthw
approved these changes
Sep 2, 2026
arthw
added
the
merge ready
Titaniumtown
approved these changes
Sep 4, 2026
Contributor
|
Thank you @johnkarlhill for the contribution! |
fewtarius
pushed a commit
to fewtarius/CachyLLama
that referenced
this pull request
Sep 5, 2026
x1250
pushed a commit
to x1250/llama.cpp
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refactor GGML_SYCL_ENABLE_MKL_FA env var read once at startup, not per-call.
Additional information
Make a consistent pattern with g_ggml_sycl_fa_decode_kernel and g_ggml_sycl_fa_onednn.
Same default (1=enabled), same env var name, same semantics.
Just moved from static local to global.
Requirements
PR #26689 (same branch base).... responding to arthw review point 4.