-
Notifications
You must be signed in to change notification settings - Fork 21.8k
model: add MTP support for Nemotron model #26725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,156 @@ | ||
| #include "models.h" | ||
|
|
||
| std::unique_ptr<llm_graph_context> llama_model_nemotron_h_moe::build_arch_graph(const llm_graph_params & params) const { | ||
| if (params.gtype == LLM_GRAPH_TYPE_DECODER_MTP) { | ||
| return std::make_unique<graph_mtp>(*this, params); | ||
| } | ||
| return std::make_unique<graph>(*this, params); | ||
| } | ||
|
|
||
| // MTP draft head for Nemotron-H MoE | ||
| llama_model_nemotron_h_moe::graph_mtp::graph_mtp(const llama_model & model, const llm_graph_params & params) | ||
| : llm_graph_context(params) { | ||
| GGML_ASSERT(hparams.n_layer_nextn == 1 && "NEMOTRON_H_MOE MTP currently supports a single MTP block"); | ||
|
|
||
| const int64_t n_embd_head = hparams.n_embd_head_v(); | ||
| GGML_ASSERT(n_embd_head == hparams.n_embd_head_k()); | ||
|
|
||
| const int il = hparams.n_layer(); | ||
| const auto & layer = model.layers[il]; | ||
|
|
||
| GGML_ASSERT(layer.nextn.eh_proj && layer.nextn.enorm && layer.nextn.hnorm); | ||
| GGML_ASSERT(layer.ffn_gate_inp); | ||
|
|
||
| // token embedding weights | ||
| ggml_tensor * tok_embd_w = layer.nextn.embed_tokens ? layer.nextn.embed_tokens : model.tok_embd; | ||
| GGML_ASSERT(tok_embd_w != nullptr && "NEMOTRON_H_MOE MTP requires token embeddings"); | ||
|
|
||
| auto inp = std::make_unique<llm_graph_input_embd_h>(hparams.n_embd); | ||
|
|
||
| inp->tokens = ggml_new_tensor_1d(ctx0, GGML_TYPE_I32, n_tokens); | ||
| ggml_set_input(inp->tokens); | ||
|
|
||
| inp->embd = ggml_new_tensor_2d(ctx0, GGML_TYPE_F32, hparams.n_embd_inp(), n_tokens); | ||
| ggml_set_input(inp->embd); | ||
|
|
||
| ggml_tensor * tok_embd; | ||
| if (ubatch.token) { | ||
| tok_embd = ggml_get_rows(ctx0, tok_embd_w, inp->tokens); | ||
| } else { | ||
| tok_embd = inp->embd; | ||
| } | ||
| cb(tok_embd, "mtp_tok_embd", il); | ||
|
|
||
| inp->h = ggml_new_tensor_2d(ctx0, GGML_TYPE_F32, hparams.n_embd, n_tokens); | ||
| ggml_set_input(inp->h); | ||
| ggml_set_name(inp->h, "mtp_h_input"); | ||
|
|
||
| ggml_tensor * h_embd = inp->h; | ||
|
|
||
| res->add_input(std::move(inp)); | ||
|
|
||
| ggml_tensor * inp_out_ids = build_inp_out_ids(); | ||
|
|
||
| // attention fills KV over all tokens, but the MoE is position-wise: gather output rows before | ||
| // it to save FFN compute (unless unmasked embeddings_nextn needs the full-length hidden state) | ||
| const bool emit_h_nextn = cparams.embeddings_nextn; | ||
| const bool crop_before_ffn = inp_out_ids && (!emit_h_nextn || cparams.embeddings_nextn_masked); | ||
|
|
||
| auto * inp_attn = build_attn_inp_kv(); | ||
|
|
||
| ggml_tensor * h_norm = build_norm(h_embd, layer.nextn.hnorm, nullptr, LLM_NORM_RMS, il); | ||
| cb(h_norm, "mtp_hnorm", il); | ||
| ggml_tensor * e_norm = build_norm(tok_embd, layer.nextn.enorm, nullptr, LLM_NORM_RMS, il); | ||
| cb(e_norm, "mtp_enorm", il); | ||
|
|
||
| ggml_tensor * concat = ggml_concat(ctx0, e_norm, h_norm, /*dim=*/ 0); | ||
| cb(concat, "mtp_concat", il); | ||
|
|
||
| ggml_tensor * cur = build_lora_mm(layer.nextn.eh_proj, concat, layer.nextn.eh_proj_s); | ||
| cb(cur, "mtp_eh_proj", il); | ||
|
|
||
| // dense NoPE attention sub-layer (mtp.layers.0) | ||
| ggml_tensor * inpSA = cur; | ||
| cur = build_norm(cur, layer.attn_norm, nullptr, LLM_NORM_RMS, il); | ||
| cb(cur, "mtp_attn_norm", il); | ||
|
|
||
| { | ||
| auto [Qcur, Kcur, Vcur] = build_qkv(layer, cur, n_embd_head, hparams.n_head(il), hparams.n_head_kv(il), il); | ||
| const float kq_scale = hparams.f_attention_scale == 0.0f | ||
| ? 1.0f / sqrtf(float(n_embd_head)) : hparams.f_attention_scale; | ||
| cur = build_attn(inp_attn, layer.wo, layer.wo_b, layer.wo_s, | ||
| Qcur, Kcur, Vcur, nullptr, nullptr, nullptr, kq_scale, il); | ||
| cb(cur, "mtp_attn_out", il); | ||
| } | ||
|
|
||
| cur = ggml_add(ctx0, cur, inpSA); | ||
| cb(cur, "mtp_attn_residual", il); | ||
|
|
||
| // gather the output rows here so the MoE FFN below only runs on the positions we keep | ||
| if (crop_before_ffn) { | ||
| cur = ggml_get_rows(ctx0, cur, inp_out_ids); | ||
| } | ||
|
|
||
| // MoE FFN sub-layer (mtp.layers.1) | ||
| ggml_tensor * ffn_residual = cur; | ||
| cur = build_norm(cur, layer.attn_post_norm, nullptr, LLM_NORM_RMS, il); | ||
| cb(cur, "mtp_attn_post_norm", il); | ||
|
|
||
| { | ||
| ggml_tensor * router_logits = build_lora_mm(layer.ffn_gate_inp, cur); | ||
| cb(router_logits, "mtp_ffn_moe_logits", il); | ||
|
|
||
| ggml_tensor * moe_out = | ||
| build_moe_ffn(cur, | ||
| layer.ffn_gate_inp, | ||
| layer.ffn_up_exps, | ||
| nullptr, // no gate | ||
| layer.ffn_down_exps, | ||
| layer.ffn_exp_probs_b, | ||
| n_expert, n_expert_used, | ||
| LLM_FFN_RELU_SQR, hparams.expert_weights_norm, | ||
| hparams.expert_weights_scale, | ||
| LLAMA_EXPERT_GATING_FUNC_TYPE_SIGMOID, | ||
| il, | ||
| router_logits, nullptr, | ||
| layer.ffn_up_exps_s, | ||
| nullptr, // no gate | ||
| layer.ffn_down_exps_s); | ||
| cb(moe_out, "mtp_ffn_moe_out", il); | ||
|
|
||
| ggml_tensor * ffn_shexp = build_ffn(cur, | ||
| layer.ffn_up_shexp, NULL, layer.ffn_up_shexp_s, | ||
| NULL, NULL, NULL, | ||
| layer.ffn_down_shexp, NULL, layer.ffn_down_shexp_s, | ||
| NULL, | ||
| LLM_FFN_RELU_SQR, LLM_FFN_PAR, il); | ||
| cb(ffn_shexp, "mtp_ffn_shexp", il); | ||
|
|
||
| cur = ggml_add(ctx0, moe_out, ffn_shexp); | ||
| cb(cur, "mtp_ffn_out", il); | ||
| } | ||
|
|
||
| cur = ggml_add(ctx0, cur, ffn_residual); | ||
| cb(cur, "mtp_post_ffn", il); | ||
|
|
||
| // final head norm: the MTP head has its own LayerNorm | ||
| GGML_ASSERT(layer.nextn.shared_head_norm && "NEMOTRON_H_MOE MTP: missing final head norm"); | ||
| cur = build_norm(cur, layer.nextn.shared_head_norm, nullptr, LLM_NORM, -1); | ||
|
|
||
| cb(cur, "h_nextn", -1); | ||
| res->t_h_nextn = cur; | ||
|
|
||
| if (!crop_before_ffn && inp_out_ids) { | ||
| cur = ggml_get_rows(ctx0, cur, inp_out_ids); | ||
| } | ||
|
|
||
| // LM head | ||
| ggml_tensor * head_w = layer.nextn.shared_head_head ? layer.nextn.shared_head_head : model.output; | ||
| ggml_tensor * head_s = layer.nextn.shared_head_head ? layer.nextn.shared_head_head_s : model.output_s; | ||
| GGML_ASSERT(head_w != nullptr && "NEMOTRON_H_MOE MTP requires an output projection"); | ||
| cur = build_lora_mm(head_w, cur, head_s); | ||
| cb(cur, "result_output", -1); | ||
|
|
||
| res->t_logits = cur; | ||
| ggml_build_forward_expand(gf, cur); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
inp_out_idsgather can happen at this line, before the MoE FFN.We need only attention to run over all
n_tokensto fill KV.This should help improve prefill perf a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I moved the
inp_out_idsgather before the MoE FFN so attention still runs over all tokens while the MoE only processes the kept rows.Guarded it the same way
mimo2does (crop_before_ffn = inp_out_ids && (!embeddings_nextn || embeddings_nextn_masked)).