convert : fix DeepseekV4 rope parameters with transformers 5.x - #26673
Merged
Conversation
Member
ggerganov
approved these changes
Aug 6, 2026
ggerganov
left a comment
ggerganov
left a comment
Member
There was a problem hiding this comment.
Looks like the conversion now picked up the YARN params correctly.
CISC
added
the
merge ready
Member
|
Btw, we should add a warning to |
Member
Author
Yeah, probably a good idea. Another good idea was splitting the model on metadata, only a 5MB download to get the update. :) |
miltos22
pushed a commit
to miltos22/llama.cpp-wackMall-merge-request
that referenced
this pull request
Aug 10, 2026
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 11, 2026
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 12, 2026
huaxel
pushed a commit
to huaxel/CachyLLama
that referenced
this pull request
Aug 12, 2026
brittlewis12
pushed a commit
to brittlewis12/llama.cpp
that referenced
this pull request
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Converting DeepseekV4 with
transformers5.xwould result in missing rope parameters (YaRN).Additional information
The issue was caused by
transformersusing a specialrope_parameterslayout for this model, see configuration_deepseek_v4.py for more details.Requirements