Skip to content

metal: fix threadgroup half4x4 compilation error in lightning indexer #26646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggerganov merged 2 commits into from
Aug 7, 2026
+2 −2
Merged

metal: fix threadgroup half4x4 compilation error in lightning indexer #26646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ec1cfd
fix(metal): avoid `threadgroup` matrix array instantiation in kernel_…
JamePeng Aug 5, 2026
f78513f
Merge branch 'ggml-org:master' into fix/metal-threadgroup-constructor
JamePeng Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ggml/src/ggml-metal/ggml-metal.metal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11328,8 +11328,8 @@ kernel void kernel_lightning_indexer(
const int i_kv_0 = tgpig.x*NK; // first key of this threadgroup
const int i_kv = i_kv_0 + sgitg*NKPSG; // first key of this simdgroup

threadgroup half4x4 sk4x4[NK*DK16];
threadgroup half * sk = (threadgroup half *) sk4x4;
threadgroup half sk[NK * DK16 * 16];
threadgroup half4x4 * sk4x4 = (threadgroup half4x4 *) sk;

for (short i = tiitg; i < NK*DK16; i += NTG) {
const short ik = i/DK16;
Expand Down
Loading