dont (immedietly) promote fa-auto -> fa-on - #26553
Open
JorisBolsens wants to merge 1 commit into
Open
Conversation
|
This was a gotcha for me when I didn't realize my llama-server was compiled without FA_ALL_QUANTS. Silently offloading to CPU should not be a default behavior; such a warning would have saved a lot of confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
in #25871 if FA was set to AUTO and ctv is quantized, then it automatically sets FA to enabled. That causes the check on
src/llama-context.cpp:550to never run, and causes the guard onsrc/llama-context.cpp:459to never trip. Which means flash attention automatically offloads to CPU in case it is not supported in backend (often when ctk != ctv)There is no log line showing this is happening, which means performance is quietly degraded, and debugging is very difficult.
Requirements