tests : avoid building get-model.cpp many times - #26317
Merged
Merged
Conversation
ggerganov
commented
Jul 30, 2026
| { "ggml-org/gemma-3-4b-it-GGUF", "Q8_0" }, | ||
| { "bartowski/Meta-Llama-3.1-70B-Instruct-GGUF", "Q4_K_M" }, | ||
| { "bartowski/deepseek-ai_DeepSeek-V3.1-GGUF", "IQ1_M" }, | ||
| //{ "bartowski/Qwen_Qwen3.5-397B-A17B-GGUF", "IQ1_S" }, // TODO: swap with ggml-org if/when it's released |
Member
Author
There was a problem hiding this comment.
@bartowski1182 The Qwen3.5-397B quant seems to have changed, so I commented it out to avoid the test failing.
Contributor
There was a problem hiding this comment.
I noticed a similar issue with some models in the chat template tests for models that had existed for years, not sure why it happens, no worries, this has lived here long enough to know it works fine without this one model
(aka go ahead and delete the line if you'd like)
ngxson
approved these changes
Jul 30, 2026
bartowski1182
approved these changes
Jul 30, 2026
satindergrewal
added a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 2, 2026
…nkling preprocessor Upstream ggml-org#26317 deleted tests/get-model.cpp (moved into common). Upstreams mtmd-image.cpp refactor dropped our inkling image preprocessor (from PR ggml-org#25731 snapshot); re-spliced the helper + override, verified build+link.
kashif
pushed a commit
to kashif/llama.cpp
that referenced
this pull request
Aug 2, 2026
* tests : remove get-model.cpp * tests : fix quant type selection
huaxel
pushed a commit
to huaxel/CachyLLama
that referenced
this pull request
Aug 2, 2026
* tests : remove get-model.cpp * tests : fix quant type selection
smalinin
pushed a commit
to smalinin/llama.cpp
that referenced
this pull request
Aug 4, 2026
* tests : remove get-model.cpp * tests : fix quant type selection
huaxel
pushed a commit
to huaxel/CachyLLama
that referenced
this pull request
Aug 6, 2026
* tests : remove get-model.cpp * tests : fix quant type selection
huaxel
pushed a commit
to huaxel/CachyLLama
that referenced
this pull request
Aug 10, 2026
* tests : remove get-model.cpp * tests : fix quant type selection
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 11, 2026
* tests : remove get-model.cpp * tests : fix quant type selection
satindergrewal
added a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 11, 2026
…nkling preprocessor Upstream ggml-org#26317 deleted tests/get-model.cpp (moved into common). Upstreams mtmd-image.cpp refactor dropped our inkling image preprocessor (from PR ggml-org#25731 snapshot); re-spliced the helper + override, verified build+link.
satindergrewal
pushed a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 12, 2026
* tests : remove get-model.cpp * tests : fix quant type selection
satindergrewal
added a commit
to satindergrewal/llama.cpp
that referenced
this pull request
Aug 12, 2026
…nkling preprocessor Upstream ggml-org#26317 deleted tests/get-model.cpp (moved into common). Upstreams mtmd-image.cpp refactor dropped our inkling image preprocessor (from PR ggml-org#25731 snapshot); re-spliced the helper + override, verified build+link.
huaxel
pushed a commit
to huaxel/CachyLLama
that referenced
this pull request
Aug 15, 2026
* tests : remove get-model.cpp * tests : fix quant type selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Noticed that this source file gets compiled for almost every tests, so moved the function to
libllama-commonto avoid that.Requirements